Issue Summary

After upgrading the Atlassian Troubleshooting and Support Tools (ATST) plugin to version 1.58.0, Jira Data Center instances with an unlimited user license are incorrectly receiving warnings that they are approaching their license limit. The warning indicates that the instance has reached its warning limit of 10% remaining seats, which should not be applicable for unlimited licenses. This issue was not present before the upgrade and appears to be a regression or unintended consequence of the new feature introduced in ATST 1.58.0.

This is reproducible on Data Center: Yes

Steps to Reproduce

1. Ensure Jira Data Center instance is running with an unlimited user license.
2. Update the Atlassian Troubleshooting and Support Tools plugin to version 1.58.0.
3. Observe the License Limit Health Check warnings indicating that the instance is approaching its license limit with 10% remaining seats.

Expected Results

Instances with an unlimited user license should not receive warnings about approaching license limits, as their user count is not constrained by a numeric limit.

Actual Results

Jira Data Center instances with unlimited user licenses are incorrectly warned about nearing license limits, specifically being notified that only 10% of seats remain, which contradicts the nature of an unlimited license.

The below exception is thrown in the atlassian-jira.log:

2024-06-20 16:41:40,549-0400 support-zip WARN user1 1001x427x1 xxxxxx xxx.xx.xx.xxx,xxx.xxx.xxx.xxx,xxx.xxx.xxx.xxx /rest/troubleshooting/latest/support-zip/local [c.a.t.healthcheck.concurrent.SupportHealthCheckProcess] Health check 'Jira Service Management license limit' failed with severity 'warning': 'Your Jira Service Management instance has reached its warning limit of 10% remaining seats. To prevent your instance exceeding the user limit, you can:' 

Workaround

Currently, the known workaround for this behavior, is to disable the  feature as mentioned in the following article:

• Health Check: Jira License Limit